Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlConfiguration jetty.webapps.uri is the uri of the webapp not the parent dir #3399

Closed
janbartel opened this issue Feb 26, 2019 · 2 comments
Closed

XmlConfiguration jetty.webapps.uri is the uri of the webapp not the parent dir #3399

janbartel opened this issue Feb 26, 2019 · 2 comments
Assignees
@janbartel

Comments

@janbartel
Copy link
Contributor

https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-xml/src/main/java/org/eclipse/jetty/xml/XmlConfiguration.java#L155

The property is called "jetty.webapps.uri", but the actual value is the uri of the webapp being configured, not its parent dir, but the "jetty.webapps" property contains the path of the parent dir.
@janbartel janbartel self-assigned this Mar 5, 2019
janbartel added a commit that referenced this issue Mar 6, 2019
@janbartel
Issue #3399 jetty.webapps.uri should be the parent of the webapp
0074c00 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Mar 6, 2019
Merged
@joakime
Copy link
Contributor

joakime commented Mar 11, 2019

Opened PR #3430

janbartel added a commit that referenced this issue Mar 13, 2019
@janbartel
Issue #3399 jetty.webapps.uri should be the parent of the webapp (#3430)
de5d041 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel
Copy link
Contributor Author

Fix applied to jetty-10.0.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakime @janbartel