Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow jetty WebSockets to be upgraded using WebSocketUpgradeFilter in jetty-10 #3446

Closed
lachlan-roberts opened this issue Mar 10, 2019 · 0 comments
Closed

allow jetty WebSockets to be upgraded using WebSocketUpgradeFilter in jetty-10 #3446

lachlan-roberts opened this issue Mar 10, 2019 · 0 comments

Comments

@lachlan-roberts
Copy link
Contributor

currently in jetty-10 WebSockets using the jetty api can only be upgraded through the WebSocketServlet, we should reintroduce the functionality to allow upgrades though the WebSocketUpgradeFilter as well
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - jetty-websocket tests for WebSocketUpgradeFilter
9edcc10 
Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - allow jetty-websocket upgrades with WebSocketUpgra…
f9dee4d 
…deFilter

JettyWebSocketServerContainer moved out of internal and is now used
in a similar way to the Javax server container, and can now be
used to configure upgrades using the shared mapping with
the WSUpgradeFilter

the JettyWSSCI now works in the same way as the JavaxWSSCI, the
JettyWebSocketEmbeddedStarter has been removed and the configureContext
now returns the JettyWebSocketServerContainer

WebSocket upgrade failures due to exceptions will now be logged as
a warning in WebSocketMapping rather than being ignored

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - renaming and code cleanup
8cc4ab3 
rename WebSocketSessionImpl to WebSocketSession

remove SessionListener which is unused and replaced by
WebSocketSessionListener

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - renaming, code cleanup and fixes
906057b 
rename WebSocketSessionImpl to WebSocketSession

remove SessionListener which is unused and replaced by
WebSocketSessionListener

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - renaming, code cleanup and fixes
c537763 
rename WebSocketSessionImpl to WebSocketSession

remove SessionListener which is unused and replaced by
WebSocketSessionListener

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - changes from review
2b1b909 
use the same FrameHandlerFactory for WebSocketServlet and
WebSocketUpgradeFilter

removed addMapping with PathSpec and only support addMapping
with String

JettyWebSocketServerContainer now implements WebSocketPolicy which
configures the FrameHandler.Customizer

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - jetty-websocket tests for WebSocketUpgradeFilter
265e0be 
Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - allow jetty-websocket upgrades with WebSocketUpgra…
e9df97e 
…deFilter

JettyWebSocketServerContainer moved out of internal and is now used
in a similar way to the Javax server container, and can now be
used to configure upgrades using the shared mapping with
the WSUpgradeFilter

the JettyWSSCI now works in the same way as the JavaxWSSCI, the
JettyWebSocketEmbeddedStarter has been removed and the configureContext
now returns the JettyWebSocketServerContainer

WebSocket upgrade failures due to exceptions will now be logged as
a warning in WebSocketMapping rather than being ignored

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - renaming, code cleanup and fixes
e355ec3 
rename WebSocketSessionImpl to WebSocketSession

remove SessionListener which is unused and replaced by
WebSocketSessionListener

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - changes from review
337d543 
use the same FrameHandlerFactory for WebSocketServlet and
WebSocketUpgradeFilter

removed addMapping with PathSpec and only support addMapping
with String

JettyWebSocketServerContainer now implements WebSocketPolicy which
configures the FrameHandler.Customizer

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 11, 2019
@lachlan-roberts
Issue jetty#3446 - changes from review
8f727be 
use the same FrameHandlerFactory for WebSocketServlet and
WebSocketUpgradeFilter

removed addMapping with PathSpec and only support addMapping
with String

JettyWebSocketServerContainer now implements WebSocketPolicy which
configures the FrameHandler.Customizer

Signed-off-by: lachan-roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Mar 13, 2019
@gregw
Merge pull request #3448 from lachlan-roberts/jetty-10.0.x-cometd5
61484a1 
Issue #3446 - upgrade jetty-websockets with WebSocketUpgradeFilter
@lachlan-roberts lachlan-roberts mentioned this issue Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts