Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing moved Extension classes from jetty-websocket-api #3453

Closed
lachlan-roberts opened this issue Mar 12, 2019 · 2 comments
Closed

Removing moved Extension classes from jetty-websocket-api #3453

lachlan-roberts opened this issue Mar 12, 2019 · 2 comments
Assignees
@joakime

Comments

@lachlan-roberts
Copy link
Contributor

classes defining jetty-api extensions exist such as

Extension
ExtensionFactory
IncomingFrames
OutgoingFrames

but these don't seem to be used or tested anywhere
@joakime
Copy link
Contributor

joakime commented Mar 12, 2019 •
edited
Loading

Most of the extension behaviors have been moved to websocket-core as they are not API dependent.

To document for future viewers of this issue ...

  • org.eclipse.jetty.websocket.api.extensions.Extension is now at org.eclipse.jetty.websocket.core.Extension
  • org.eclipse.jetty.websocket.api.extensions.ExtensionFactory is now at org.eclipse.jetty.websocket.core.WebSocketExtensionRegistry
  • org.eclipse.jetty.websocket.api.extensions.IncomingFrames is now at org.eclipse.jetty.websocket.core.IncomingFrames
  • org.eclipse.jetty.websocket.api.extensions.OutgoingFrames is now at org.eclipse.jetty.websocket.core.OutgoingFrames

joakime added a commit that referenced this issue Mar 12, 2019
@joakime
Issue #3453 - Removing deprecated Extension classes in jetty-websocke…
469ba84 
…t-api

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 12, 2019
@joakime
Issue #3453 - Removing deprecated Extension classes in jetty-websocke…
8a0fff9 
…t-api

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor

joakime commented Mar 12, 2019

Opened PR #3455

@joakime joakime self-assigned this Mar 12, 2019
@joakime joakime changed the title user supplied extensions are not implemented through the jetty-websocket-api in jetty 10.0.x Removing moved Extension classes from jetty-websocket-api Mar 12, 2019
gregw added a commit that referenced this issue Mar 13, 2019
@gregw
Merge pull request #3455 from eclipse/jetty-10.0.x-3453-remove-deprec…
8b2b626 
…ated-websocket-extension-api

Issue #3453 - Removing deprecated Extension classes in jetty-websocket-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakime @lachlan-roberts