XmlConfiguration set from property

[gregw]

The jetty xml files have many Set clauses like:

        <Set name="forwardedHostHeader"><Property name="jetty.httpConfig.forwardedHostHeader" default="X-Forwarded-Host"/></Set>

This means that during startup the setter is always called and there is a default value in the XML. It may improve startup time and reduce the duplication of default values if we implemented the following:

        <Set name="forwardedHostHeader" property="jetty.httpConfig.forwardedHostHeader"/>

where the setter is only called if the property is actually set.

[gregw]

@sbordet @joakime @janbartel thoughts?

[joakime]

+1 from me, I'm good with that syntax.

[janbartel]

I think it's a good idea. Just have to be sure some XML files aren't relying on the default value being set.

[gregw]

@janbartel I've been reviewing the XMLs as I modify them and keeping defaults if they differ from what the class does by itself. I'd say I'm only 98% on this and need to review some more.... but the exercise does show how annoying it is to have defaults in more than one place!