Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueuedThreadPool should reset thread interrupted on failed run #4122

Closed
joakime opened this issue Sep 25, 2019 · 0 comments
Closed

QueuedThreadPool should reset thread interrupted on failed run #4122

joakime opened this issue Sep 25, 2019 · 0 comments
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Sep 25, 2019

The logic found in QueuedThreadPool.Runner.run() appears to not handle the Thread.interrupted() if the runJob(job) call throws an exception.

https://github.com/eclipse/jetty.project/blob/ba728eee5d9e8cfd3b7449b1246546ca2306bb25/jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java#L911-L930
@joakime joakime added the Bug For general bugs on Jetty side label Sep 25, 2019
gregw added a commit that referenced this issue Oct 2, 2019
@gregw
Issue #4122 QueuedThreadPool
c37a4ff 
Always clear the interrupted status

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw mentioned this issue Oct 2, 2019
Merged
gregw added a commit that referenced this issue Oct 2, 2019
@gregw
Jetty 9.4.x 4105 4121 4122 queued thread pool (#4146)
813fcb7 
Several QTP fixes:

* #4105 Threads without jobs now check if they should idle die before waiting rather than before, this allows idling under steady load. 3ad6780
* #4121 ThreadFactory behaviour supported by doing thread config within newThread call. 7b306d7
* #4122 Always clear the interrupted status. c37a4ff
   task = queue.poll(timeout);

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregw @joakime