Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty-10 WebSocketSession stopped twice by SessionTracker #4315

Closed
lachlan-roberts opened this issue Nov 15, 2019 · 0 comments
Closed

Jetty-10 WebSocketSession stopped twice by SessionTracker #4315

lachlan-roberts opened this issue Nov 15, 2019 · 0 comments
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

SessionTracker.doStop() stops all the active Sessions, this initiates a SHUTDOWN close on the session which will call SessionTracker.onWebSocketSessionClosed() when it is done and this will also try to stop the Session.
@lachlan-roberts lachlan-roberts self-assigned this Nov 15, 2019
lachlan-roberts added a commit that referenced this issue Nov 18, 2019
@lachlan-roberts
Issue #4315 - stop WebSocketSessions only after onClose
738de7b 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Nov 18, 2019
Merged
lachlan-roberts added a commit that referenced this issue Nov 27, 2019
@lachlan-roberts
Issue #4315 - Jetty and Javax WebSocketSessions are no longer LifeCycles
2410f9d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Nov 27, 2019
@lachlan-roberts
Merge pull request #4324 from eclipse/jetty-10.0.x-4315-OnlyStopWSSes…
9dbdb97 
…sionsOnce

Issue #4315 - stop WebSocketSessions only after onClose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts