Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a parameterless CustomRequestLog #4460

Closed
sbordet opened this issue Jan 7, 2020 · 1 comment · Fixed by #4470
Closed

Provide a parameterless CustomRequestLog #4460

sbordet opened this issue Jan 7, 2020 · 1 comment · Fixed by #4470

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 7, 2020

Jetty version
10.0.x

Description
Currently, CustomRequestLog requires constructor parameters.
This does not play well with the Jetty Maven Plugin, which expects a RequestLog instance, but it's going to be difficult to instantiate from a pom.xml file.

While it is true that custom RequestLog configurations may be provided with a Jetty XML file, simple usages will benefit from a parameterless CustomRequestLog.

Example in CometD 6:

<plugin>
  <groupId>org.eclipse.jetty</groupId>
  <artifactId>jetty-maven-plugin</artifactId>
  <configuration>
    <requestLog implementation="org.eclipse.jetty.server.Slf4jRequestLog" /> // Present in Jetty 9.4.x, but not in 10.0.x. 
    ...
  </configuration>
</plugin>
@sbordet
Copy link
Contributor Author

sbordet commented Jan 7, 2020

@janbartel opinions about this?

sbordet added a commit that referenced this issue Jan 9, 2020
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jan 9, 2020
…t_log_no_parameters

Fixes #4460 - Provide a parameterless CustomRequestLog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant