Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlConfiguration constructor selection based on number of arguments #4550

Closed
gregw opened this issue Feb 6, 2020 · 2 comments · Fixed by #4553
Closed

XmlConfiguration constructor selection based on number of arguments #4550

gregw opened this issue Feb 6, 2020 · 2 comments · Fixed by #4553

Comments

@gregw
Copy link
Contributor

gregw commented Feb 6, 2020

Jetty version
9.4.x, 10.0.x

Java version
Perc Virtual Machine

See comment on #4086 regarding arguments
gregw added a commit that referenced this issue Feb 6, 2020
@gregw
Fixes #4550 XmlConfiguration named parameters
d27f4ee 
Fixed #4550 named parameters with a moderate refactor.
The named parameter matching was duplicated, only considering number of args and not applied to call arguments.    This refactor puts all the behaviour in common methods and reorders the arguments to match parameters.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw mentioned this issue Feb 6, 2020
Merged
gregw added a commit that referenced this issue Feb 6, 2020
@gregw
Fixes #4550 XmlConfiguration named parameters
2c8d405 
Do not match a missing varArgs executable is there is a matching method with no varArgs.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@sbordet
Copy link
Contributor

sbordet commented Feb 7, 2020

@gregw what's this issue about? The link to the issue seems wrong.

@joakime joakime linked a pull request Feb 12, 2020 that will close this issue
Fixes #4550 XmlConfiguration named parameters #4553
Merged
@rrorden rrorden mentioned this issue Feb 13, 2020
Merged
@joakime joakime linked a pull request Feb 13, 2020 that will close this issue
Issue #1036 Configure Scheduler #4086
Merged
@joakime joakime removed a link to a pull request Feb 13, 2020
Issue #1036 Configure Scheduler #4086
Merged
@gregw gregw closed this as completed Feb 16, 2020
@joakime
Copy link
Contributor

joakime commented Feb 19, 2020

Reopening as 9.4.27 version on PR #4553 is not merged yet.

@joakime joakime reopened this Feb 19, 2020
sbordet added a commit that referenced this issue Feb 20, 2020
@sbordet
Merge pull request #4553 from eclipse/jetty-9.4.x-4550-XmlConfigurati…
ea5b70b 
…on-named-args

Fixes #4550 XmlConfiguration named parameters
@sbordet sbordet closed this as completed Feb 20, 2020
gregw added a commit that referenced this issue Feb 22, 2020
@gregw
Issue #4550 XmlConfiguration argument matching
2073003 
Improve argument matching by:
 + rejecting obviously non matches (with allowance for unboxing)
 + sorting methods so that derived arguments are tried before more generic (eg String before Object)

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 22, 2020
@gregw
Issue #4550 XmlConfiguration argument matching
f35522c 
Improve argument matching by:
 + can unbox from any Number to any Number

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 24, 2020
@gregw
Issue #4550
d6843a9 
Do not check the assignability of the arguments.  Instead rely on the order of the methods.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 24, 2020
@gregw
Issue #4550
3728314 
unbox test no longer required

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 25, 2020
@gregw
Issue #4550
626fe71 
Simplified test

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 25, 2020
@gregw
Issue #4550
39dd245 
Cleanup comparator

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 25, 2020
@gregw
Issue #4550
a95e40e 
Cleanup comparator

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Feb 25, 2020
@gregw
Issue #4550 XmlConfiguration argument matching (#4599)
353dc9b 
* Issue #4550 XmlConfiguration argument matching

Improve argument matching by:
 + rejecting obviously non matches (with allowance for unboxing)
 + sorting methods so that derived arguments are tried before more generic (eg String before Object)

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4550 XmlConfiguration argument matching

Improve argument matching by:
 + can unbox from any Number to any Number

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4550

Do not check the assignability of the arguments.  Instead rely on the order of the methods.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4550

unbox test no longer required

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4550

Simplified test

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4550

Cleanup comparator

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4550

Cleanup comparator

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw mentioned this issue Feb 25, 2020
Merged
@joakime joakime mentioned this issue Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4550 XmlConfiguration named parameters jetty/jetty.project
3 participants
@gregw @joakime @sbordet