Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short list of Jetty modules #5254

Closed
sbordet opened this issue Sep 10, 2020 · 8 comments
Closed

Short list of Jetty modules #5254

sbordet opened this issue Sep 10, 2020 · 8 comments
Assignees

Comments

@sbordet
Copy link
Contributor

sbordet commented Sep 10, 2020

Jetty version
10.0.x

Description
Would be great if users could explore what modules are available in a fresh install of Jetty:

java -jar $JETTY_HOME/start.jar --show-modules

where --show-modules produces a shorter output rather than the current 799 😮 lines of output, where the modules available are completely lost in the amount of other information.

The output of --show-modules would be something like:

Module: alpn 
Module: annotations 
Module: apache-jsp 
Module: apache-jstl 
Module: bytebufferpool 
Module: client 
Module: decorate 
Module: deploy 
Module: fcgi 
...

Maybe with a short description.

@gregw
Copy link
Contributor

gregw commented Sep 11, 2020

We already have --list-modules, which has descriptions, dependencies etc plus a filtering mechanism

@gregw
Copy link
Contributor

gregw commented Sep 11, 2020

i wouldn't object to making "show" a synonym for "list" in all our options.... plus "--add" should be the same as "--add-to-start"

@sbordet
Copy link
Contributor Author

sbordet commented Sep 11, 2020

@gregw --list-modules produces 800 lines of output.

@janbartel
Copy link
Contributor

I find it confusing to have both --show-xxx and --list-xxx. Also to me --show-xxx implies more detailed info than --list-xxx. How about we keep just --list-modules and either add --verbose or alternatively --quiet to change the amount of info output??

@gregw
Copy link
Contributor

gregw commented Sep 11, 2020

Then let's improve the format of --list-modules, with the default being more compact, perhaps leaving out the dependencies.
Maybe we then have a --show-module=name,name,.... that shows the full details of the given modules?

@sbordet
Copy link
Contributor Author

sbordet commented Sep 11, 2020

Any solution would work for me.

My point is that a user would probably like to see the list of available modules to glance interesting ones:

oh, hey, there is a statistics module, and look, a rewrite module too!

@gregw
Copy link
Contributor

gregw commented Sep 11, 2020

OK - I'll do this one.

@gregw gregw self-assigned this Sep 11, 2020
gregw added a commit that referenced this issue Sep 11, 2020
 * simplified --list-modules output
 * added --show-module

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Sep 14, 2020
* Issue #5254 List/Show modules

 * simplified --list-modules output
 * added --show-module

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* improve module descriptions

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw
Copy link
Contributor

gregw commented Sep 16, 2020

@WalkerWatch #5257 included an update to the module descriptions... but can you review them in a new PR to improve the voice of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants