New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create demo module #5264

Closed

joakime opened this issue Sep 14, 2020 · 1 comment · Fixed by #5292

Assignees

Labels

Enhancement High Priority

Contributor

joakime commented Sep 14, 2020

Jetty version
10.0.x

Description
In light of the changes for Issue #5256, we need to migrate the existing demo-base to a new demo module.

This should probably exist in the /examples/demo-module/ directory in source control.

It might make sense to also have the individual test webapps be modules themselves that the new demo module just depends on.
It could make adding a test webapp for request dump only purposes quite handy.

We should review the maven coordinates of all of the test webapps, as some of them are not aligned properly.

The text was updated successfully, but these errors were encountered:

joakime added the Enhancement label

Contributor

gregw commented Sep 14, 2020

We already have a demo.mod that configures the demo, so i think that just needs to be moved to somewhere that can be pulled into the standard modules of jetty-home and the mod file modified to pull in the webapps and config files needed either from a demo.d and/or from maven

gregw added a commit that referenced this issue


          Issue #5264 Demo modules

52a0fdf

Create modules in jetty-home to download and deploy demos

gregw linked a pull request

that will close this issue

Issue #5264 Demo modules #5292

Merged

gregw mentioned this issue

Issue #5264 Demo modules #5292

Merged

joakime added a commit that referenced this issue


          Issue #5264 - Supporting snapshot maven repo metadata in start.jar

e338310

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Supporting extract of maven archive to destination

ba78355

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Reworking modules to live at "home" classfied artifact …

5a089c0

…locations

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Reworking test-distribution to use jetty-home

4ecff26

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Disabling jetty-distribution from build reactor

d0b8a31

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Reworking demo/tests into modules based on config class…

8a64309

…ifiers

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing deploy status on demo webapps

533d64c

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Removing compact3 build

817533f

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing demo-jndi config

c002305

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

gregw added a commit that referenced this issue


          Issue #5264 Jetty Home warning

b00ec5a

Warn when using jetty home as a jetty base

joakime added a commit that referenced this issue


          Issue #5264 - Fixing demo-jndi deps for javax.mail

770f251

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

gregw added a commit that referenced this issue


          Issue #5264 Jetty Home warning

5d3643e

updates from review

gregw added the High Priority label

gregw assigned joakime

gregw added a commit that referenced this issue


          Issue #5263 Jetty Home warning (#5309)

592dfb8

* Issue #5264 Jetty Home warning

Warn when using jetty home as a jetty base

* Issue #5304 HTTP2 HostHeader

 + updated more options doco and handling

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #5264 Jetty Home warning

updates from review

joakime added a commit that referenced this issue


          Issue #5264 - Changing Distro to Home in jetty-maven-plugin

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Removing 12 hour expired test (too time of day sensitive)

9d43259

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Removing unused variable

797b267

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Moving demo webapps to /demos/ tree

faf6d80

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Updating embedded JettyDistro to JettyHome

934a95b

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Updating Configure DTD to 10_0 for Demos

1feb60b

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Adding demo.mod support to embedded examples tests

bdf30ba

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Work around junit-vintage flappy test error

d4556e4

+ ApacheDS has old school testing lib which doesn't
  play nice with surefire.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing jetty-maven-plugin exclusions for demos

f7cf411

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - More post move to /demos/ updates

ad805d4

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing test-integration references to demos

c9be742

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Javadoc processing excludes for demos

413eb4c

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Adding HostHeaderCustomizer to H2/H2C Transport tests

9a2d6cd

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - More javadoc skippedModules

23b6eca

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 -Fixing name

5d73b42

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - making embedded examples more reliable

0f3c41c

+ Discovering ${jetty.version} better
+ Creating ${jetty.base}/logs/ on JettyDemoBase usage

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - identifying optional deps in jetty-home

b567339

 + Done to ease dependency / exclusions listing requirements
   elsewhere in the reactor.
   (Prevents accidental discovered components from
    triggering actions during use of jetty-home
    as a dependency)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing OSGi tests

32875aa

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing demo-async-rest module reference

73fe2ec

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Fixing OSGi symbolic name references

3dbedd8

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #5264 - Addressing (some) aggregate-javadoc issues

35bca82

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime closed this as completed in #5292

dependabot bot added a commit that referenced this issue


          Issue #5264 -Fixing name

c2bf5b7

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment