Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more filtering for CustomRequestLog #5817

Closed
joakime opened this issue Dec 16, 2020 · 2 comments · Fixed by #6176
Closed

Provide more filtering for CustomRequestLog #5817

joakime opened this issue Dec 16, 2020 · 2 comments · Fixed by #6176
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented Dec 16, 2020

Jetty version
9.4.35+

Description
The current CustomRequestLog has only 1 filter option, which is the request uri path.

Provide more filtering options.

  • Response status code (very useful)
  • Content-Type (can narrow down specific behaviors)
  • User-Agent (can identify specific user agents you are interested in)

I think just supporting a BiPredicate<Request,Response> on CustomRequestLog which is used in .log(Request,Response) should be the maximally flexible option.
Complex rules can be done with BiPredicate composition (.and(), .or(), and .not()) or with custom BiPredicate behaviors.

@rk1165
Copy link
Contributor

rk1165 commented Dec 17, 2020

Hi @joakime ,
I followed the class and method you mentioned. How do I start working on it, can you please help me?
I have already cloned the project, signed the contributor agreement and subscribed to the mailing list. Is there anything else I need to do?
Also, please let me know if there's any prerequisite I need to read up or anything.

@lachlan-roberts
Copy link
Contributor

@rk1165 there's no prerequisites other than signing the ECA. If you want to help out and work on this you can implement this feature on your branch, write some junit tests for it, then you can create a pull request to the jetty-9.4.x branch. You should sign your commits with the email you used to sign the ECA. Then the PR will be reviewed and merged if it is approved and passes all the tests.

lachlan-roberts added a commit that referenced this issue Apr 15, 2021
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 27, 2021
…LogFiltering

Issue #5817 - allow CustomRequestLog to be filtered with BiPredicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants