Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Jetty IO uses SocketAddress instead of InetSocketAddress #6410

Closed
sbordet opened this issue Jun 15, 2021 · 1 comment · Fixed by #6414
Closed

Ensure Jetty IO uses SocketAddress instead of InetSocketAddress #6410

sbordet opened this issue Jun 15, 2021 · 1 comment · Fixed by #6414
Assignees
@sbordet
Labels
Enhancement

Comments

@sbordet
Copy link
Contributor

sbordet commented Jun 15, 2021

Target Jetty version(s)
10.0.x

Enhancement Description
In preparation for support of Unix Domain Sockets, introduced in Java 16 and handled in #6043, many Jetty I/O classes should be changed to return/use SocketAddress instead of InetSocketAddress.

As this is a quite large change that is better done separately.
@sbordet sbordet self-assigned this Jun 15, 2021
sbordet added a commit that referenced this issue Jun 15, 2021
@sbordet
Fixes #6410 - Use SocketAddress instead of InetSocketAddress.
2387a00 
Removed usages of InetSocketAddress in method signatures where possible.
Deprecated old methods, and added new methods with SocketAddress.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 15, 2021
@sbordet
Fixes #6410 - Use SocketAddress instead of InetSocketAddress.
f34c541 
Restored fake socket addresses in ByteArrayEndPoint,
as too many tests depend on these fake socket addresses.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 15, 2021
@sbordet
Fixes #6410 - Use SocketAddress instead of InetSocketAddress.
6fea335 
Fixed handling of the LOCAL command: everything past it must be ignored as per specification.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@joakime
Copy link
Contributor

joakime commented Jun 15, 2021

This is related to Issue #2134

@joakime joakime linked a pull request Jun 15, 2021 that will close this issue
Fixes #6410 - Use SocketAddress instead of InetSocketAddress. #6414
Merged
@sbordet sbordet mentioned this issue Jun 15, 2021
Closed
sbordet added a commit that referenced this issue Jun 17, 2021
@sbordet
Fixes #6410 - Use SocketAddress instead of InetSocketAddress. (#6414)
b8d6e3f 
* Fixes #6410 - Use SocketAddress instead of InetSocketAddress.

Removed usages of InetSocketAddress in method signatures where possible.
Deprecated old methods, and added new methods with SocketAddress.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@joakime joakime changed the title Use SocketAddress instead of InetSocketAddress Ensure Jetty IO uses SocketAddress instead of InetSocketAddress Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #6410 - Use SocketAddress instead of InetSocketAddress. jetty/jetty.project
2 participants
@joakime @sbordet