Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultSessionCache more extensible using ConcurrentMap #6752

Closed
prenagha opened this issue Sep 9, 2021 · 1 comment · Fixed by #6753 or #6758
Closed

DefaultSessionCache more extensible using ConcurrentMap #6752

prenagha opened this issue Sep 9, 2021 · 1 comment · Fixed by #6753 or #6758
Labels
Enhancement

Comments

@prenagha
Copy link
Contributor

prenagha commented Sep 9, 2021

Target Jetty version(s)
10.x
11.x

Enhancement Description
DefaultSessionCache is designed to be extended, by virtue of its protected session map. Subclasses can set their own map instance instead. However the session map is specified as ConcurrentHashMap, when it only needs to be ConcurrentMap.
Changed data type to ConcurrentMap to allow for wider options for subclasses, such as those wanted to use Caffeine's asMap() method which returns ConcurrentMap.
Although changing to even more relaxed Map would work, that does not provide as much clarity that the map will be used concurrently - therefore used ConcurrentMap instead.
@prenagha
Copy link
Contributor Author

prenagha commented Sep 9, 2021

PR coming shortly

@prenagha prenagha mentioned this issue Sep 9, 2021
Merged
joakime added a commit that referenced this issue Sep 9, 2021
@joakime
Issue #6752 - Extensible DefaultSessionCache map implementation
bc3fa13 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue Sep 9, 2021
Merged
janbartel pushed a commit that referenced this issue Sep 10, 2021
@prenagha
Issue #6752 DefaultSessionCache more extensible using ConcurrentMap (#…
96945c7 
…6753)

DefaultSessionCache is designed to be extended, by virtue of its protected session map. Subclasses can set their own map instance instead. However the session map is specified as ConcurrentHashMap, when it only needs to be ConcurrentMap.
Changed data type to ConcurrentMap to allow for wider options for subclasses, such as those wanted to use Caffeine's asMap() method which returns ConcurrentMap.
Although changing to even more relaxed Map would work, that does not provide as much clarity that the map will be used concurrently - therefore used ConcurrentMap instead.

Signed-off-by: Padraic Renaghan <padraic@renaghan.com>
joakime added a commit that referenced this issue Sep 14, 2021
@joakime
Issue #6752 - Extensible DefaultSessionCache map implementation
bff69b3 
Addressing changes requested from review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2021
@joakime
Issue #6752 - Extensible DefaultSessionCache map implementation
8788aae 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2021
@joakime
Issue #6752 - Extensible DefaultSessionCache map implementation
8991b7f 
Addressing changes requested from review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2021
@joakime
Issue #6752 - Extensible DefaultSessionCache map implementation
a223815 
More changes requested from review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2021
@joakime
Merge pull request #6758 from eclipse/jetty-10.0.x-extensible-default…
51f6a58 
…-session-cache

Issue #6752 - Extensible DefaultSessionCache map implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
1 participant
@prenagha