MimeTypes resource loading incorrect on OSGi

[mbechler]

Starting with 9.3.11 (#723) fails to load the bundled mime type resources in OSGI and logs two warnings.

The new code seems to load the resources through HashMap's (== bootstrap, with Loader falling back to system) classloader with is quite obviously wrong and should be MimeTypes.class or something like that.

[gregw]

@janbartel I've switched the loader class to MimeTypes, but we probably should have a unit test for this, can you look at that?

[gregw]

@janbartel Note also that in 9.4.x we no longer have a class argument to the loader, so a different solution will be required.

[janbartel]

@gregw the solution to both 9.3 and 9.4 behaviour is to simply re-instate the use of the ResourceBundle instead of Loader.getResource(): ResourceBundle uses the classloader of the MimeTypes class, which is what is desired.

[janbartel]

@mbechler FYI issue #705 is also relevant for jetty-9.4. Although in this case the problem will be solved if we revert to using ResourceBundle to load the mime types, in general if using in an osgi environment, you'll need to have a reasonable thread context classloader set up before accessing jetty classes.

[mbechler]

Wouldn't using MimeTypes.class.getClassLoader().getResource(..) solve all the issues at hand (for MimeTypes, extension loading is of course a different beast)? Doesn't do ResourceBundle's magic, does not use Loader and uses the correct classloader.

[janbartel]

@mbechler actually ClassLoader.getResource() implements the java classloader search order, which is parent first. So it will actually try the parent first (or bootstrap classloader if there is no parent) before failing back to the actual classloader. So that doesn't seem totally ideal either. However,I've changed it to use your suggestion in jetty-9.3 and beyond. I'll close this issue for now, but let us know if there are any problems.