Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10158 Change ignored deployment message to WARN #10321

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Issue #10158 Change ignored deployment message to WARN #10321

merged 1 commit into from
Aug 18, 2023

Conversation

janbartel
Copy link
Contributor

WRT #10158 I think it's better to change the DEBUG message about an ignored deployment due to lack of an environment to a WARN.

@janbartel janbartel requested review from gregw and joakime August 16, 2023 05:38
@janbartel janbartel self-assigned this Aug 16, 2023
@janbartel janbartel merged commit 33ef0b0 into jetty-12.0.x Aug 18, 2023
@janbartel janbartel deleted the jetty-12.0.x-10158-change-deploy-ignore-message branch August 18, 2023 01:19
@joakime joakime mentioned this pull request Aug 23, 2023
Closed
sbordet added a commit that referenced this pull request Aug 30, 2023
@sbordet
Reverted #10321.
4289529 
The warning message was causing confusion in case of multiple deployers.
See also #10437.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@gregw gregw gregw approved these changes

Assignees

@janbartel janbartel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janbartel @gregw @joakime