Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12.0.x use automatic formatter for poms to have same style for every poms #10578

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Jetty 12.0.x use automatic formatter for poms to have same style for every poms #10578

merged 7 commits into from
Oct 12, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Sep 26, 2023

  • setup spotless for poms only
  • spotless:apply to all poms

@olamy olamy mentioned this pull request Sep 26, 2023
Closed
@olamy
Copy link
Member Author

olamy commented Sep 26, 2023

issue #6924

@olamy olamy force-pushed the jetty-12.0.x-sortpom branch from d22699d to f56155a Compare September 26, 2023 02:32
@joakime
Copy link
Contributor

joakime commented Sep 26, 2023

Looks cool.

Can this organize the dependency lists as well?
Like we do with our java source import lines?

@olamy olamy force-pushed the jetty-12.0.x-sortpom branch from 48b65d7 to ec8c6e6 Compare September 27, 2023 08:35
@olamy
Copy link
Member Author

olamy commented Sep 27, 2023

@joakime yes dependencies sorting added, by groupId, artifactId

joakime
joakime approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but lets talk with the rest of the group about when to merge this.

pom.xml Show resolved Hide resolved
@olamy olamy force-pushed the jetty-12.0.x-sortpom branch from c3b2175 to 53c0e81 Compare October 11, 2023 02:35
olamy added 4 commits October 12, 2023 06:50
@olamy
appply spotless sort pom
848d637 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
add spotless plugin version
c1cc2ae 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
add some exclusions
ddef15f 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
declared used dependency, do not sort modules
d56b405 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the jetty-12.0.x-sortpom branch from 7c30fb2 to d56b405 Compare October 11, 2023 20:50
olamy added 3 commits October 12, 2023 09:28
@olamy
spotless pom fix
4e1d132 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
remove hamcrest-core as it is duplicate with hamcrest
0ad6adf 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
exclude some files from cache scanner
d2928aa 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit fcc8827 into jetty-12.0.x Oct 12, 2023
2 checks passed
@olamy olamy deleted the jetty-12.0.x-sortpom branch October 12, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 12.0.3 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olamy @joakime @gregw