Merge 11 to 12 Issue #10731 wrong context attribute name javax.servlet instead of jakarta.servlet (#10735) and Address build/test failure against bad entities. (#10742) #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
changed the title
lachlan-roberts
previously approved these changes
Oct 17, 2023
…karta.servlet (#10735) * Issue #10731 wrong context attribute name javax.servlet instead of jakarta.servlet Signed-off-by: Olivier Lamy <olamy@apache.org> * Update jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java Co-authored-by: Simone Bordet <simone.bordet@gmail.com> * Update jetty-server/src/main/java/org/eclipse/jetty/server/Request.java Co-authored-by: Simone Bordet <simone.bordet@gmail.com> * fix javadoc Signed-off-by: Olivier Lamy <olamy@apache.org> * more usage of constant Signed-off-by: Olivier Lamy <olamy@apache.org> --------- Signed-off-by: Olivier Lamy <olamy@apache.org> Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Bad entities in test case can lead to: * external URL references * required HTTP GET requests * not testing redirectEntity / resolveEntity (the whole point of the test) Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
force-pushed
the
jetty-12.0.x-merge-11
branch
from
75bf414 to
fe0fbdd
Compare
|
@lachlan-roberts thanks I have cleaned them up (the comments doesn't matter much) |
lachlan-roberts
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy olamy@apache.org
Co-authored-by: Simone Bordet simone.bordet@gmail.com
Co-authored-by: Simone Bordet simone.bordet@gmail.com
Signed-off-by: Olivier Lamy olamy@apache.org
Signed-off-by: Olivier Lamy olamy@apache.org
Signed-off-by: Olivier Lamy olamy@apache.org
Co-authored-by: Simone Bordet simone.bordet@gmail.com