Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP/3 Client handling of MAX_FIELD_SECTION_SIZE setting #10763

Merged

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Oct 20, 2023

Upon receiving a SETTINGS frame from the server, the MAX_FIELD_SECTION_SIZE setting was mistakenly checked on the client against the response headers size instead of the request headers size.

Fixes #10759

…ue against H3 config setting maxRequestHeadersSize

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban added the Bug For general bugs on Jetty side label Oct 20, 2023
@lorban lorban added this to the 10.0.x milestone Oct 20, 2023
@lorban lorban requested a review from sbordet October 20, 2023 13:32
@lorban lorban self-assigned this Oct 20, 2023
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great find!

@lorban lorban merged commit 59105be into jetty-10.0.x Oct 20, 2023
2 checks passed
@lorban lorban deleted the fix/jetty-10-10759-fix-flaky-testRequestHeadersTooLarge branch October 20, 2023 15:14
@joakime joakime changed the title Fix client setting MAX_FIELD_SECTION_SIZE handling Fix HTTP/3 Client handling of MAX_FIELD_SECTION_SIZE setting Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix HTTP/3 Client handling of MAX_FIELD_SECTION_SIZE setting
3 participants