Fixes #10879 - Improve redirect handling with reproducible content #10880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now both the redirect and the authentication ProtocolHandlers will abort the request on response success. If the request is already completed, the abort attempt will be a no-op, proceeding as usual. Otherwise, the request upload will be aborted and a new request sent with the reproducible content. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Olivier Lamy <olamy@apache.org>
lorban
approved these changes
Nov 13, 2023
sbordet
added a commit
that referenced
this pull request
Aug 26, 2024
…ntent. This avoids the rare case where the response arrives before the request thread has modified the request state, even if the request has been fully sent over the network, causing the request to be failed even if it should not. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this pull request
Aug 30, 2024
* Reworked HttpReceiverOverHTTP state machine, in particular: ** Introduced a boolean parameter to parseAndFill() and parse(), that specifies whether to notify the application demand callback. This is necessary because reads may happen from any threads, and must not notify the application demand callback. Only when there is no data, and fill interest is set, then the application demand callback must be notified. ** Removed action field to avoid lambda allocation. ** Now the application is called directly from the parse() method. ** Reading -1 from the network drives the parser by calling again parse(), rather than the parser directly. This allows to have a central place to notify the response success event. * Fixed FastCGI similarly to HTTP/1.1. * Removed leftover of the multiplex implementation. * Fixed test flakyness in `NetworkTrafficListenerTest`: consume the request content before sending the response. * Follow up after #10880: only abort the request if there is request content in `AuthenticationProtocolHandler` and `RedirectProtocolHandler`. This avoids the rare case where the response arrives before the request thread has modified the request state, even if the request has been fully sent over the network, causing the request to be failed even if it should not. * added `SerializedInvoker` assertions about current thread invoking. * Name all SerializedInvoker instances for better troubleshooting. Signed-off-by: Simone Bordet <simone.bordet@gmail.com> Signed-off-by: Ludovic Orban <lorban@bitronix.be> Co-authored-by: Ludovic Orban <lorban@bitronix.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now both the redirect and the authentication ProtocolHandlers will abort the request on response success. If the request is already completed, the abort attempt will be a no-op, proceeding as usual. Otherwise, the request upload will be aborted and a new request sent with the reproducible content.