Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Resource use in MetaInfConfiguration #10889
Improve Resource use in MetaInfConfiguration #10889
Changes from all commits
473afb5
2aa8f34
4feecd9
19ed557
1a51854
70afc89
c44c319
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strongly discouraged by Java now. (using URL in a Set or any kind of comparison or hashcode/equals logic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, as we're passing this on to the Apache Jasper implementation we need to support what they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Apache Jasper Implementation uses a collection of
org.apache.tomcat.util.descriptor.tld.TldResourcePath
.Internally, Apache Jasper uses String and URI, not URL.
The
Set<URL>
is entirely on us, not Apache Jasper.See
org.eclipse.jetty.ee10.apache.jsp.JettyTldPreScanned
which also does not useSet<URL>
too.