#11353 offer named virtual thread executor #11430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2024
danishnawab
commented
Feb 21, 2024
| } | ||
| catch (Throwable x) | ||
| { | ||
| return null; |
There was a problem hiding this comment.
To be consistent with the existing API style (e.g. getDefaultVirtualThreadsExecutor), I return null here instead of propagating the exception.
Since org.eclipse.jetty.util.VirtualThreads.Configurable#setVirtualThreadsExecutor checks for virtual thread support as well as executor (and throws an UnsupportedOperationException otherwise), we should be fine here.
sbordet
approved these changes
Feb 21, 2024
gregw
approved these changes
Feb 21, 2024
|
@danishnawab Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #11353 (comment).
Add
VirtualThreads.getNamedVirtualThreadsExecutor(String namePrefix)as a commodity to be used by users/libraries.This PR supersedes #11355