Improvements and cleanups to ErrorHandler. #11556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaulted showStacks to false, to reduce false positives reported by penetration testing tools. Deprecated ErrorHandler.badMessageError(), as it was not invoked anymore. Implemented HttpStreamOverHTTP[2|3].onBadMessage() that was left as TODO. Simplified the same code for HTTP/1. Moved invocation of ComplianceViolation.Listener.onRequestEnd() to HandlerInvoker.completeStream(). Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
reviewed
Mar 22, 2024
| */ | ||
| @Deprecated(since = "12.0.8", forRemoval = true) | ||
| public ByteBuffer badMessageError(int status, String reason, HttpFields.Mutable fields) |
There was a problem hiding this comment.
Is this really not called anymore by things like the HttpParser?
There was a problem hiding this comment.
No it is not.
In Jetty 11 it was called by HttpChannel, but in Jetty 12 we handle failures differently by always calling HttpChannel.onFailure().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@sbordet the CI failures are due to the new way we create a request in onFailure |
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@gregw yes I'm on it. I decided to restore the creation of the error request in HTTP/1.1 because it has more information. |
gregw
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulted showStacks to false, to reduce false positives reported by penetration testing tools.
Deprecated ErrorHandler.badMessageError(), as it was not invoked anymore.
Implemented HttpStreamOverHTTP[2|3].onBadMessage() that was left as TODO.
Simplified the same code for HTTP/1.
Moved invocation of ComplianceViolation.Listener.onRequestEnd() to HandlerInvoker.completeStream().