Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11420 - fix dynamic table referencing in QpackDecoder #11645

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Issue #11420 - fix dynamic table referencing in QpackDecoder #11645

merged 4 commits into from
Apr 16, 2024

Conversation

lachlan-roberts
Copy link
Contributor

Issue #11420

Some places in the QPACK decoding were using absolute index instead of relative index.

@lachlan-roberts
Issue #11420 - fix dynamic table referencing in QpackDecoder
600dbfe 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
PR #11645 - fix calculation for relative index from an Entry
fa5c6aa 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from sbordet April 11, 2024 04:37
@lachlan-roberts lachlan-roberts linked an issue Apr 11, 2024 that may be closed by this pull request
HTTP/3 Race with Dynamic Table referencing in QPackDecoder #11420
Closed
sbordet
sbordet requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a full client/server test that reproduces the issue?
Just to be sure that the interactions of the various components in H3 works as expected.

...tp3/jetty-http3-qpack/src/main/java/org/eclipse/jetty/http3/qpack/internal/QpackContext.java Outdated Show resolved Hide resolved
.../jetty-http3/jetty-http3-qpack/src/test/java/org/eclipse/jetty/http3/qpack/EvictionTest.java Outdated Show resolved Hide resolved
...tty-http3-qpack/src/main/java/org/eclipse/jetty/http3/qpack/internal/table/DynamicTable.java Outdated Show resolved Hide resolved
...tty-http3-qpack/src/main/java/org/eclipse/jetty/http3/qpack/internal/table/DynamicTable.java Outdated Show resolved Hide resolved
@lachlan-roberts
PR #11645 - changes from review
8f19a29 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
PR #11645 - add end-to-end test for dynamic table reference
284083e 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from sbordet April 15, 2024 03:43
@lachlan-roberts lachlan-roberts merged commit ea79827 into jetty-12.0.x Apr 16, 2024
10 checks passed
@lachlan-roberts lachlan-roberts deleted the jetty-12.0.x-11420-qpackDecoder branch April 16, 2024 01:27
@lachlan-roberts lachlan-roberts mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 12.0.9 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP/3 Race with Dynamic Table referencing in QPackDecoder
2 participants
@lachlan-roberts @sbordet