Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-Antora documentation. #12131

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Aug 2, 2024

Now the documentation has been migrated to Antora, so there is no need for the Java Asciidoctor plugin, and the directories that previously held the documentation using the Asciidoctor Maven plugin.

Updated the javadoc-url attribute with the correct URI.

Renamed the version attribute to jetty-version, and now using the POM value, rather than a hard-coded one.

Removed references to Asciidoctor from the main POM.

Now the documentation has been migrated to Antora, so there is no need for the Java Asciidoctor plugin, and the directories that previously held the documentation using the Asciidoctor Maven plugin.

Updated the `javadoc-url` attribute with the correct URI.

Renamed the `version` attribute to `jetty-version`, and now using the POM value, rather than a hard-coded one.

Removed references to Asciidoctor from the main POM.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested a review from jmcc0nn3ll August 2, 2024 13:05
Copy link
Contributor

@jmcc0nn3ll jmcc0nn3ll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, clearer and some good improvements.

@sbordet sbordet merged commit 576b7d7 into jetty-10.0.x Aug 3, 2024
11 checks passed
@sbordet sbordet deleted the fix/jetty-10.0.x/remove-non-antora-docs branch August 3, 2024 08:44
@olamy olamy mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants