Issue #12173 Ignore dependencies of type pom for the webapp classpath #12177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
approved these changes
Aug 20, 2024
olamy
approved these changes
Aug 20, 2024
janbartel
deleted the
jetty-12.0.x-12173-jetty-maven-plugin-pom-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12173
In previous versions of jetty, we added all dependencies of the webapp to the webapp's classpath as a
Fileor aString. In jetty-12 we are converting all dependencies intojar:fileurls, which isn't appropriate for a.pomfile. I've fixed this by avoiding considering.pomfiles as being eligible for the classpath (in the same way we don't consider.warfiles as eligible).