Improve the documentation for the Jetty Server Dump #12205
+109
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
gregw
requested changes
Sep 2, 2024
documentation/jetty/modules/programming-guide/pages/troubleshooting/jetty-server-dump.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/troubleshooting/jetty-server-dump.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/troubleshooting/jetty-server-dump.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/troubleshooting/jetty-server-dump.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
sbordet
requested changes
Sep 5, 2024
There was a problem hiding this comment.
@lachlan-roberts can you please restore the documentation as it was?
Let's discuss what you did not like, but we really want to keep the separation between operations and programming guide.
Comment on lines
+43
to
+44
| Standalone Jetty uses two properties to control this behaviour which are referenced in `jetty.xml` to call these setters. | ||
| These properties are `jetty.server.dumpAfterStart` and `jetty.server.dumpBeforeStop`. |
There was a problem hiding this comment.
No, this is why previously the documentation was split.
This is the programming guide and referring to properties that are used only in the operations guide is not the correct place.
|
@lachlan-roberts status if this PR? |
gregw
requested changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the Jetty Server Dump documentation and split it out from
troubleshooting/index.adocto its own page which can be linked more easily.