Restore the OpenID documentation #12234
Open
+242
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
sbordet
requested changes
Sep 5, 2024
| @@ -11,27 +11,12 @@ | |||
| // ======================================================================== | |||
| // | |||
|
|
|||
| package org.eclipse.jetty.security.siwe.example; | |||
| package org.eclipse.jetty.docs.programming.security.siwe; | |||
There was a problem hiding this comment.
We don't need an extra package siwe, I think we can just put the documentation examples for security in the security package.
Comment on lines
+108
to
+110
|
|
||
|
|
||
|
|
| To enable OpenID support, you first need to activate the `openid` module in your implementation. | ||
|
|
||
| ---- | ||
| $ java -jar $JETTY_HOME/start.jar --add-to-start=openid |
There was a problem hiding this comment.
This is the programming guide.
This section should be moved to the operations guide.
|
Please also rebase on 12.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore OpenID documentation from the jetty 11 branch at
documentation/jetty-documentation/src/main/asciidoc/old_docs/security.