Issue #12309 replaced transient keyword for SessionAuthentication.session #12310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
approved these changes
Sep 25, 2024
janbartel
deleted the
jetty-12.0.x-12309-transient-SessionAuthentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12309
The
transientkeyword was removed from theSessionAuthenticationclass private data memberSession session. This leads to problems because theSessionAuthenticationitself is stored in thesessionduring some forms of authentication, such as form or openid. Thus, if thesessionneeds to be passivated, there is a backpointer to itself.