Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12356 Do not send keep-alive when not persistent #12375

Merged
merged 16 commits into from
Oct 15, 2024
Merged

Fix #12356 Do not send keep-alive when not persistent #12375

merged 16 commits into from
Oct 15, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Oct 11, 2024

Fix #12356 Do not send keep-alive when not persistent

@gregw
Fix #12356 Do not send keep-alive when not persistent
7dd5f5f 
Fix #12356 Do not send keep-alive when not persistent
@gregw gregw added the Bug For general bugs on Jetty side label Oct 11, 2024
@gregw gregw requested review from joakime and sbordet October 11, 2024 03:36
@gregw gregw mentioned this pull request Oct 11, 2024
Closed
sbordet
sbordet previously approved these changes Oct 11, 2024
View reviewed changes
@joakime
Copy link
Contributor

joakime commented Oct 11, 2024

Test failure with ...

org.eclipse.jetty.server.HttpConnectionTest.testConnectionBehavior([22] HTTP/1.0, keep-alive, Other, keep-alive, Fields, Other, keep-alive, Fields)

@gregw gregw requested a review from sbordet October 11, 2024 22:44
@joakime
Copy link
Contributor

joakime commented Oct 12, 2024

Still a whole bunch of HttpClient tests failures against HTTP/1.0 that pay attention to the keep-alive fields.

@gregw
Copy link
Contributor Author

gregw commented Oct 13, 2024

@sbordet @joakime I had to make more changes to make this work. This is now feeling very fragile, so I'm going to try a bit of a clearer refactor.

gregw and others added 7 commits October 14, 2024 11:02
@gregw
Fix #12356 Do not send keep-alive when not persistent
1b233be 
refactor to make less fragile
@gregw
Fix #12356 Do not send keep-alive when not persistent
a3a5c3c 
refactor to make less fragile
@gregw
Fix #12356 Do not send keep-alive when not persistent
0aedc8c 
refactor to make less fragile
@gregw
Fix #12356 Do not send keep-alive when not persistent
6e52cfa 
refactor to make less fragile
@gregw
Fix #12356 Do not send keep-alive when not persistent
b5dbd3c 
updates from review
@sbordet
Fixed reference to KeyStore.
b66c392 
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
Modernized and expanded testing for ConnectHandler.
c9e8d10 
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
sbordet previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few fixes, LGTM.

@sbordet
Updated HttpGenerator to handle Upgrade responses.
4192d73 
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@gregw gregw requested a review from sbordet October 15, 2024 00:48
@gregw gregw merged commit 50bced4 into jetty-12.0.x Oct 15, 2024
10 checks passed
@gregw gregw deleted the fix/12356/noKeepAliveUnlessPersistent branch October 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.15 FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeIOException: Parser is terminated when doing lots of requests with Connection: Keep-Alive
3 participants
@gregw @joakime @sbordet