-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #12397 - Add more default excludes to GzipHandler. #12414
Conversation
+ Exclude more compressed mime-types + Exclude more compressed path extensions + Add missing compressed file types to mime.properties
@gregw with this change, I see yet another thing that MimeTypes should probably do (flag if a mime-type represents compressed content that shouldn't be recompressed). What do you think about refactoring the MimeTypes configuration files a great deal? We could use json, and our jetty-util-ajax lib ... [
"application/gzip" : {
"extensions": [ ".gz", ".gzip" ],
"assumedCharset": "",
"inferredCharset": ""
"ignoreCharset": "true"
"compressedType": "true"
},
"application/json" : {
"extensions": [ ".json" ],
"assumedCharset": "utf-8",
"inferredCharset": ""
"ignoreCharset": "false"
"compressedType": "false"
}
] The idea is that this becomes our preferred configuration file, but we still allow the use of the older |
_mimeTypes.exclude("application/compress"); | ||
_paths.exclude("*.z"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems a very broad brush stroke. Also I don't see this mimetype listed on https://www.iana.org/assignments/media-types/media-types.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was taken from our mime.properties file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes
Fixes: #12397