Clarify and document execution strategy #12442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Oct 31, 2024
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/Invocable.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/Invocable.java
Outdated
Show resolved
Hide resolved
sbordet
reviewed
Oct 31, 2024
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
requested changes
Nov 4, 2024
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/Invocable.java
Outdated
Show resolved
Hide resolved
|
@gregw a typo fix and a suggested alternative for the javadocs of EITHER. |
lorban
requested changes
Nov 4, 2024
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Show resolved
Hide resolved
…ead/Invocable.java Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
requested changes
Nov 4, 2024
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/Invocable.java
Outdated
Show resolved
Hide resolved
This reverts commit b1f6b3a.
sbordet
requested changes
Nov 4, 2024
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
...modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ArchitectureDocs.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/Invocable.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/Invocable.java
Outdated
Show resolved
Hide resolved
Applied suggestions from @sbordet Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
|
@sbordet good suggestions. All applied |
lorban
approved these changes
Nov 5, 2024
sbordet
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve javadoc and code clarity