Issue #12272 - Potential deadlock with Vaadin. #12506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
previously approved these changes
Nov 11, 2024
Fixed the case where a GOAWAY followed by a TCP FIN was causing a race between closing the `EndPoint` and running the failure `Runnable` task. The TCP FIN after the GOAWAY causes the streams to be failed on the server; in turn, failing the streams generates failure `Runnable` tasks that are submitted to the HTTP/2 execution strategy; however, the streams were destroyed before the failure `Runnable` tasks actually ran, so the `EndPoint` was closed; closing the `EndPoint` would close the `HTTP2Connection`, which in turn would stop the execution strategy; this lead to the fact that the failure `Runnable` tasks were never run. Now, the failure `Runnable` tasks are invoked via `ThreadPool.executeImmediately()` rather than being submitted to the execution strategy. This ensures that they would be run and not queued, even in case of lack of threads, so that they could unblock blocked reads or writes, freeing up blocked threads. Additionally, improved `HTTP2Stream.onFailure()` to destroy the stream only after the failure tasks have completed. Smaller other fixes to improve the code. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
force-pushed
the
fix/jetty-12.0.x/12272/h2-shutdown-pending-request
branch
from
7b9b156 to
713a308
Compare
lorban
approved these changes
Nov 12, 2024
| await().atMost(5, TimeUnit.SECONDS).until(() -> !session.getEndPoint().isOpen()); | ||
|
|
||
| // Cleanup. | ||
| dataList.forEach(Stream.Data::release); |
There was a problem hiding this comment.
The cleanup could be done right after awaiting !dataList.isEmpty()
| await().atMost(5, TimeUnit.SECONDS).until(() -> !session.getEndPoint().isOpen()); | ||
|
|
||
| // Cleanup. | ||
| dataList.forEach(Stream.Data::release); |
sbordet
deleted the
fix/jetty-12.0.x/12272/h2-shutdown-pending-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case.