Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore abort for SendCallback.failed #12579

Merged

Conversation

lachlan-roberts
Copy link
Contributor

This abort was removed by #12370

but causes the failure to appengine-java-standard
when you run on PR GoogleCloudPlatform/appengine-java-standard#313

mci -pl :runtime-test -Dtest=SizeLimitHandlerTest#testResponseContentAboveMaxLength[2]

Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
@ludoch
Copy link

ludoch commented Nov 26, 2024

Weird, we are not using ee9 classes?

@lachlan-roberts
Copy link
Contributor Author

@ludoch all the code for ee8 is generated from the ee9 code.
This is because its just the namespace javax->jakarta change.

@lachlan-roberts lachlan-roberts added the Sponsored This issue affects a user with a commercial support agreement label Dec 5, 2024
@lachlan-roberts lachlan-roberts merged commit d650efe into jetty-12.0.x Dec 5, 2024
10 of 11 checks passed
@lachlan-roberts lachlan-roberts deleted the jetty-12.0.x-HttpChannel-SendCallback-abort branch December 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants