Fixed #12603 Errors logged after cross context dispatch #12606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed #12603 Errors logged after cross context dispatch: + Update bytes written in HttpOutput when bypassed by optimization + abort if error dispatch throws
joakime
reviewed
Dec 3, 2024
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/ServletCoreResponse.java
Show resolved
Hide resolved
|
@sbordet @janbartel review please! |
joakime
previously approved these changes
Dec 4, 2024
joakime
added
High Priority
Bug
sbordet
requested changes
Dec 4, 2024
| ExceptionUtil.addSuppressedIfNotAssociated(x, t); | ||
| throw x; | ||
| } | ||
| abort(x); |
There was a problem hiding this comment.
The logic is now completely different from before... Is that ok?
There was a problem hiding this comment.
That's what I'm asking you as the reviewer!)
The issue was that we have an exception whilst trying to write an error page and we handle it by trying to write an error page.... which resulted in a nasty loop. I think aborting if an error page cannot be generated is the best thing to do
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/ServletCoreResponse.java
Outdated
Show resolved
Hide resolved
Fix ee10 also
|
This issue is somewhat related to #11325 |
joakime
approved these changes
Dec 5, 2024
sbordet
approved these changes
Dec 5, 2024
|
Waiting on CI green before I merge and stage 12.0.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12603 Errors logged after cross context dispatch: