Fix #11325 Content-Length checks #12622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #11325 by: + removing content-length tracking from ServletContextResponse + adding a setContentLengthSet field to HttpOutput
sbordet
requested changes
Dec 10, 2024
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
...ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletApiResponse.java
Outdated
Show resolved
Hide resolved
.../jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletContextResponse.java
Outdated
Show resolved
Hide resolved
Fix #11325 by: + removing content-length tracking from ServletContextResponse + adding a setContentLengthSet field to HttpOutput
Fixed flaky tests due to thread local context left set.
gregw
commented
Dec 10, 2024
| @@ -1053,6 +1056,7 @@ public boolean handle(Request request, Response response, Callback callback) thr | |||
| return true; | |||
|
|
|||
| // Past this point we are calling the downstream handler in scope. | |||
| Context lastContext = getCurrentContext(); | |||
There was a problem hiding this comment.
@sbordet this is an unrelated change that was causing flaky tests as it was leaving the ThreadLocal context set on the main test thread!
Fix #11325 by: + removing content-length tracking from ServletContextResponse + adding a setContentLengthSet field to HttpOutput + added HttpOutputTest for EE10/EE11
sbordet
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11325 by: