Do not rethrow Content.Source exceptions #13614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #13613. Due to a limitation in the implementation of try-with-resource, we should avoid rethrowing the same exception. This PR makes a copy of the exception.
Fix #13613. Due to a limitation in the implementation of try-with-resource, we should avoid rethrowing the same exception. This PR makes a copy of the exception.
Fix #13613. Due to a limitation in the implementation of try-with-resource, we should avoid rethrowing the same exception. This PR makes a copy of the exception.
lorban
requested changes
Sep 24, 2025
sbordet
requested changes
Sep 25, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/ContentSinkOutputStream.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Sep 26, 2025
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
sbordet
reviewed
Sep 29, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…lures. Now that a new Chunk with a new failure is returned, retain the failure from the second read only if the second failure's cause is different from the failure of the first read. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…613-do-not-rethrow
lorban
previously approved these changes
Sep 30, 2025
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
approved these changes
Sep 30, 2025
gregw
changed the title
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.1.2 - FROZEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13613. Due to a limitation in the implementation of try-with-resource, we should avoid rethrowing the same exception. This PR makes a lazy copy of the exception in
Chunk.next(Chunk).