Limit ReservedThread creation #13837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
sbordet
requested changes
Oct 23, 2025
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ReservedThreadExecutor.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ReservedThreadExecutor.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ReservedThreadExecutor.java
Outdated
Show resolved
Hide resolved
Contributor
|
@arsenalzp also please change the 3-parameters constructor to pass 0 as default value, not -1. |
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
sbordet
approved these changes
Oct 27, 2025
sbordet
requested changes
Oct 27, 2025
Contributor
sbordet
left a comment
sbordet
left a comment
There was a problem hiding this comment.
@arsenalzp these changes broke 3 tests, see ReservedThreadExecutorTest.
Can you please take a look and understand why they failed?
Please report your findings in the PR.
Contributor
Author
The code fall down into this statement because |
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
sbordet
approved these changes
Oct 27, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.1.4 - FROZEN
Contributor
|
@arsenalzp good job! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #13707