upgrade logback and log4j-slf4j (new artifact log4j-slf4j18-impl) to support slf4j api 1.8 #3209
Conversation
…ifact log4j-slf4j18-impl) Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy
changed the title
| <version>1.8.0-beta2</version> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-slf4j18-impl</artifactId> | ||
| <version>2.11.1</version> |
There was a problem hiding this comment.
Do we really need the version here?
I would prefer it is inherited from somewhere, so that we don't forget to update it to newer versions.
There was a problem hiding this comment.
easy to fix.
I have a bit more concern about the file jetty-util/src/main/config/modules/slf4j-api.mod
and the value slf4j.version?=1.8.0-beta2 (without the change included in the pr this was not working anymore)
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
|
@olamy nice magic with the |
|
@sbordet because we do not use Spring Boot elsewhere except for this test and we probably don't want to depend on it? |
|
@olamy but the point is that if we put the version there we will never ever remember to update it for new Spring Boot versions. |
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
|
@sbordet fair enough. should be better now |
Signed-off-by: olivier lamy oliver.lamy@gmail.com