Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3166 Add autobahn profile to automatically run autobahn test suite in Jenkins #3292

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

olamy
Copy link
Member

@olamy olamy commented Jan 24, 2019

No description provided.

@olamy olamy changed the title Jetty 10.0.x autobahn profile Add autobahn profile to automatically run autobahn test suite in Jenkins Jan 24, 2019
@olamy olamy force-pushed the jetty-10.0.x_autobahn_profile branch from d291326 to a0d305e Compare January 24, 2019 02:00
@olamy olamy requested a review from gregw January 24, 2019 02:01
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than quibbles

@@ -134,9 +134,8 @@
<goal>fuzzingclient</goal>
</goals>
<configuration>
<!-- The class which contains a main method that accept the port as parameter and startup the -->
<!-- The class contains a main method that accept the port as parameter and startup the -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class that contains a main method which accepts the port as a parameter to start the server

@@ -85,6 +85,8 @@ public FrameHandler negotiate(Negotiation negotiation) throws IOException
public void customize(FrameHandler.CoreSession session)
{
session.setIdleTimeout(Duration.ofMillis(5000));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah here is the 5s! Try setting this to 10s to see if that is the cause of some failures?

@olamy olamy force-pushed the jetty-10.0.x_autobahn_profile branch from a671e29 to 47a4bdc Compare January 24, 2019 11:22
activate autobahn profile to run within jenkins

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy olamy force-pushed the jetty-10.0.x_autobahn_profile branch from 47a4bdc to ad4c888 Compare January 24, 2019 11:23
@olamy olamy changed the title Add autobahn profile to automatically run autobahn test suite in Jenkins Issue #3166 Add autobahn profile to automatically run autobahn test suite in Jenkins Jan 25, 2019
@olamy olamy merged commit 6145fd7 into jetty-10.0.x Jan 25, 2019
@olamy olamy deleted the jetty-10.0.x_autobahn_profile branch January 25, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants