Issue #3494 - flaky tests in jetty-websocket-tests ClientCloseTest #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nulling out values in WebSocketAdapter causes race conditions when trying to access session and endpoint externally Race condition in WebSocketChannel.Flusher.onCompleteFailure(), processConnectionError should be called first to ensure that the correct close reason is processed, super.onCompleteFailure() was closing the connection causing a read failure. race condition between the server detecting a read failure and sending a response and the client detecting the write failure, now blocking on the server so it is not reading and will not detect the failure Signed-off-by: lachan-roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…rror WebSocketChannel.processConnectionError now defaults to NO_CLOSE status if no protocol reasons can be found added some debug logging improvements to tests Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
joakime
approved these changes
Apr 8, 2019
| @@ -59,8 +59,7 @@ public void onWebSocketBinary(byte[] payload, int offset, int len) | |||
| @Override | |||
| public void onWebSocketClose(int statusCode, String reason) | |||
| { | |||
| this.session = null; | |||
| this.remote = null; | |||
| /* do nothing */ | |||
There was a problem hiding this comment.
If we go this route, then we MUST make sure that the session / remote are not capable of being used after onWebSocketClose
There was a problem hiding this comment.
using the session after the close has happened will result in Session.isOpen() returning false and any writes on the RemoteEndpoint are failed, so they are safe to keep around after the close
although maybe we need test cases to verify this behaviour
...-websocket-tests/src/test/java/org/eclipse/jetty/websocket/tests/client/ClientCloseTest.java
Show resolved
Hide resolved
|
@joakime I don't have the permissions to merge, so can you merge it if there's no further changes you want |
…-3494-clientclosetest Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-3494-clientclosetest
branch
from
0094dba to
002ecf5
Compare
lachlan-roberts
commented
Apr 9, 2019
...cket-common/src/main/java/org/eclipse/jetty/websocket/common/JettyWebSocketFrameHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3494
Nulling out values in
WebSocketAdaptercauses race conditions when trying to access session and endpoint externally which was causing errors in the tests, if you calladapter.getSession().close()the socket could receive a close just before null out the session and then you get a NPEThere was a race condition in
WebSocketChannel.Flusher.onCompleteFailure(), whereprocessConnectionError()should be called beforesuper.onCompleteFailure()to ensure that thecorrect close reason is processed before the channel is closed.
In
testWriteExceptionwhen the output was shutdown there was a race condition between the client detecting the write failure and the server detecting a read failure and sending a failure response.We now send a message to block the server from reading so that it will not detect the failure and respond.