-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jetty-10 WebSocket configuration refactor #3660
jetty-10 WebSocket configuration refactor #3660
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
the client and server subclasses of JavaxWebSocketContainer now share a common configuration instance which is used as the default configuration for both server and client endpoints to do this a setter was added for the configuration on the CoreClient Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
correctly detect when a message has exceeded the max size in the sink forward changes to the input buffer size to the connection in WSChannel Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
and set the configuration on supplied CoreClient to the Javax client container Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
4cbca1f
to
c40a303
Compare
...nt/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketClientContainer.java
Outdated
Show resolved
Hide resolved
a4dc88b
to
3271564
Compare
...nt/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketClientContainer.java
Outdated
Show resolved
Hide resolved
3271564
to
beae4a7
Compare
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
beae4a7
to
0b41386
Compare
configuration moved to ClientUpgradeRequest Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
...ava/org/eclipse/jetty/websocket/javax/tests/server/WebSocketServerContainerExecutorTest.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/eclipse/jetty/websocket/javax/server/JavaxWebSocketServerContainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/eclipse/jetty/websocket/javax/server/JavaxWebSocketServerContainer.java
Show resolved
Hide resolved
...er/src/main/java/org/eclipse/jetty/websocket/javax/server/JavaxWebSocketServerContainer.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts can you fix the merge issue and I'll rereview. |
…-configuration-refactor Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
39738a9
to
d6c68c4
Compare
@lachlan-roberts so the forced push (grrrrr) was just the merge ??? Now you are a committer there is absolutely no need to force push into branches as you can squash and merge the PR yourself. |
@gregw this force push was before the i got write access but it was because the first merge i did was missing things, that stopped it from compiling so I just amended it, and it was only on a commit after the review which shouldn't not break the review on github |
review of the websocket configuration paths, added improved testing for jetty-websocket configuration which exposed errors in the implementation which have now been fixed
jetty-websocket configuration
refactor of javax WebSocketContainer configuration