Issue #3762 - use the default port of 0 for WebSocket tests #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Jun 12, 2019
| static ServletContextHandler _context; | ||
|
|
||
| @BeforeAll | ||
| public static void setup() throws Exception | ||
| { | ||
| _server = new Server(); | ||
| ServerConnector connector = new ServerConnector(_server); | ||
| connector = new ServerConnector(_server); | ||
| connector.setPort(8080); |
There was a problem hiding this comment.
I couldn't figure out how to change this one because it uses xml HttpClient provider
https://github.com/eclipse/jetty.project/blob/0d9de2822670cee7e2ca16ced238594d2c1ea45f/jetty-websocket/javax-websocket-server/src/test/resources/jetty-websocket-httpclient.xml#L3-L18
There was a problem hiding this comment.
Set the arg with a property: <Arg><New ...><Arg><Property ..>... and then set externally
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
wasn't sure how to set the arg with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lachlan Roberts lachlan@webtide.com
#3762