Fix Secure javax.websocket Client examples

[lachlan-roberts]

Signed-off-by: Lachlan Roberts lachlan@webtide.com

[lachlan-roberts]

@joakime this still has some problems.

I also noticed that running the test we do not get a close response and just close with close code 1006. But in the 9.4.x version of the tests we do get a 1000 response from the server. Not sure why this is happening.

[lachlan-roberts]

The XmlBasedHttpClientProvider could not find the xml file when it was in examples/ but worked when moved up a directory to resources, so I think that the ClassLoader scope stuff below doesn't work.

If you replace this entire method with just ContainerProvider.getWebSocketContainer() it works as well.

[joakime]

The reason for not putting that into the src/test/resources root is because that change would make all tests would then use this jetty-websocket-httpclient.xml
I was limiting the scope of it's usage with all of that classloader nonsense to only the 2 Examples.

[lachlan-roberts]

Turns out the reason the xml does not work in src/test/resources/examples is because in jetty-10 we lazily create the HttpClient so that the HttpClientProvider is run during the call to client.connectToServer(echoEndpoint, clientEndpointConfig, echoUri); in main and not in the ThreadClassLoaderScope try block below.

[lachlan-roberts]

maybe these examples should be junit tests so we know they are tested and working

[joakime]

I'm not opposed to having tests.
But I'd like to keep the examples as is, as they help many individuals working with SSL on websocket.
They will be referenced on the documentation too (when I get around to it)

[lachlan-roberts]

@joakime can you review
I have removed the ClassLoader tricks as there are no as the HttpClient is lazily created in the client.connectToServer() call.

Alternatively I could just put this around the main test in the code.

try (ThreadClassLoaderScope ignore = new ThreadClassLoaderScope(classLoader))	
{	
    ...
}

[joakime]

LGTM