tck tests are done after ServletContext has already been initialized so we need to test this first to get some tck test passing... #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so we need to test this first to get some tck test passing... Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
janbartel
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
I'm going to give this a +1, however I need you to feed back to the tck people that the test is simply wrong: the javadoc for the get/setInitParameter makes very clear that you cannot call this method if the context is already started. Thus, according to the spec, container should not waste any time evaluating a parameter if it is not in the correct state to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: olivier lamy oliver.lamy@gmail.com