Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2074 no merge query string #4730

Merged
merged 6 commits into from
Mar 31, 2020

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Mar 30, 2020

As per #2074 Do not merge the query string itself, only the parameter map.
The query string is either the original or replaced by the one from the dispatch.

gregw added 5 commits March 26, 2020 13:56
+ Preserve the entire URI with query when startAsync(req,res) is used.
+ merge any query string from dispatch path with either original query or preserved query from forward

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Do not merge the query string itself, only the parameter map.
The query string is either the original or replaced by the one from the dispatch.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw added the Specification For all industry Specifications (IETF / Servlet / etc) label Mar 30, 2020
@gregw gregw requested review from janbartel, olamy and sbordet March 30, 2020 14:28
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to answers to questions in my comments, LGTM.

@gregw gregw merged commit ef9e155 into jetty-10.0.x Mar 31, 2020
@gregw gregw deleted the jetty-10.0.x-2074-noMergeQueryString branch March 31, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification For all industry Specifications (IETF / Servlet / etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants