Issue #4747 - fix some test failures for jetty-10 with websocket tck #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Using the object hash code is not random enough to use as a unique ID. Now using UUID.randomUUID() instead which sufficiently random. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
- This applies to the javax onClose method not the core onClosed method. - Also fixes a bug where onClosed may never be called if onFrame throws. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Headers with the same name may not have been copied properly for header values inspected and modified with a Configurator. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-4747-WebSocketTCK
branch
from
c053b48 to
4e69b48
Compare
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Apr 21, 2020
jetty-websocket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/CloseStatus.java
Outdated
Show resolved
Hide resolved
...cket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/WebSocketSessionState.java
Outdated
Show resolved
Hide resolved
jetty-websocket/websocket-core/src/test/resources/jetty-logging.properties
Outdated
Show resolved
Hide resolved
gregw
reviewed
Apr 21, 2020
...bsocket-core/src/main/java/org/eclipse/jetty/websocket/core/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
gregw
reviewed
Apr 21, 2020
...bsocket-servlet/src/main/java/org/eclipse/jetty/websocket/servlet/ServletUpgradeRequest.java
Show resolved
Hide resolved
…4747-WebSocketTCK
…4747-WebSocketTCK
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4747
Default close status code should be normal status.
SessionID should return same String instance. Also using the object hash code is probably not suited to be used as a unique ID and not get collisions. Now using UUID.randomUUID() instead which is sufficiently random and large enough to generate unique IDs.
Throwing in onClose now calls onError. Also fixes a bug where onClosed may never be called if onFrame throws.
Fix to make WS path parameters work when deployed with a context path.
Correctly copy headers in JsrUpgradeListener. Multiple headers with the same name did not copy properly and were lost.
Filter out synthetic methods when looking for annotated methods on a class so bridge methods are not found.
The servers websocket handshake response is allowed to not select a subprotocol from the offered subprotocols by the client as long as it does not include the subprotocol header in the response.