Jetty 9.4.x 5104 incorrect via header #5144
Conversation
…other protocols Signed-off-by: Travis Spencer <travis@curity.io>
… in Via header when accessed over H2. * Introduced HttpFields.computeField() to put/append header values. * Reworked AbstractProxyServlet.addViaHeader(). Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@joakime still does not pass ECA check so it was not the newline before For reference, we filed an issue about this ECA at Eclipse: https://bugs.eclipse.org/bugs/show_bug.cgi?id=565761 @travisspencer can you double check on your side? Maybe the ECA is expired or has been revoked? |
|
The ECA is fixed. The problem was on my end, and it wasn't easy to figure out. What happened was that I logged into my Eclipse account page, and my password manager was changing the email address field that I saw to the email address I was expecting to find -- VERY SORRY for all the trouble and thanks for the help and patience. |
| else | ||
| { | ||
| found = true; | ||
| HttpField newField = computeFn.apply(name, Collections.unmodifiableList(getFields(name))); |
There was a problem hiding this comment.
I'm not keen on this implementation as for the common cases it will create a bit more garbage than necessary. However I don't really want to hold up this PR any more, so perhaps I'll do a different PR to improve this implementation.... and look at using it in other places.
| { | ||
| HttpField newField = computeFn.apply(name, null); | ||
| if (newField != null) | ||
| put(newField); |
There was a problem hiding this comment.
working on a better impl... meanwhile use add here not put, as you have already iterated and discovered that it is not found.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
… in Via header when accessed over H2. Fixed javadocs. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
unmodifiable found list Signed-off-by: Greg Wilkins <gregw@webtide.com>
….4.x-5104-incorrect_via_header'.
… in Via header when accessed over H2. Added HttpFields.computeField() for HttpHeader too and updated usages. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
| if (viaFields == null || viaFields.isEmpty()) | ||
| return new HttpField(header, viaHeaderValue); | ||
| String separator = ", "; | ||
| String newValue = viaFields.stream() |
There was a problem hiding this comment.
I trust that this fluent style will resolve to something efficient enough for the common case of a single Via field? If not then it might not be a bad idea to have special handling for viaFields.size()==1
There was a problem hiding this comment.
@gregw lost in the rest of the proxying it's a case where I'd prefer less code than more special case handling.
The typical case is that we are the only proxy, so viaFields.size()==0, which is already optimized.
Ah! that now makes sense. So I opened an issue to get accounts.eclipse.org to fix this behavior - https://bugs.eclipse.org/bugs/show_bug.cgi?id=566041 |
What you suggest there would have helped a lot. |
No description provided.