Reorg of /demos/ with focus on demo-spec downstream dependencies. #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
@janbartel do you want these "demo-spec-*" artifacts to be used in the osgi testing too? |
janbartel
requested changes
Sep 29, 2020
There was a problem hiding this comment.
The idea was to move everything from tests/test-webapps/test-spec into demos/demo-spec instead. Everything that referred to the old location would need to be updated, including the osgi tests.
tests/test-webapps/test-mock-resources are used in a number of places, but probably could also move over to demos? demo-mock-resources should not be part of demo-spec as it is used in a number of places.
Currently stuff seems to be duplicated in both demos and tests/test-webapps.
+ Removing old /tests/ modules that no longer have a reason for existing. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ demo-jndi and demo-spec now depend on it Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
janbartel
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com