Issue #5320 - using jetty-websocket-httpclient.xml within webapp Jetty 10 #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…ests Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
requested review from
gregw and
sbordet
and removed request for
gregw
sbordet
requested changes
Nov 4, 2020
jetty-websocket/websocket-jetty-server/src/main/config/modules/websocket-jetty.mod
Outdated
Show resolved
Hide resolved
.../test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/DistributionTests.java
Show resolved
Hide resolved
gregw
reviewed
Nov 4, 2020
.../test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/DistributionTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Nov 5, 2020
| @@ -0,0 +1,24 @@ | |||
| # DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html | |||
|
|
|||
| [description] | |||
There was a problem hiding this comment.
Remove these 2 lines, the link is now obsolete with the new Jetty 10 docs.
There was a problem hiding this comment.
These lines are present on every single .mod file I can find. Maybe the change to fix all these should all be done in a separate PR?
...c/main/java/org/eclipse/jetty/websocket/client/config/JettyWebSocketClientConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/jetty/websocket/client/config/JettyWebSocketClientConfiguration.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…5320-WebSocketHttpClient2
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Nov 9, 2020
jetty-websocket/websocket-jetty-client/src/main/config/modules/websocket-jetty-client.mod
Show resolved
Hide resolved
...c/main/java/org/eclipse/jetty/websocket/client/config/JettyWebSocketClientConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Nov 9, 2020
...c/main/java/org/eclipse/jetty/websocket/client/config/JettyWebSocketClientConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/jetty/websocket/client/config/JettyWebSocketClientConfiguration.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketConfiguration.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
Nov 11, 2020
...c/main/java/org/eclipse/jetty/websocket/client/config/JettyWebSocketClientConfiguration.java
Outdated
Show resolved
Hide resolved
…5320-WebSocketHttpClient2
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5320
Make similar changes from PR #5374 for Jetty 10.
XmlHttpClientProviderso that it uses the HttpClient's classloaderwebsocket-jetty-client.jarto jetty-home/lib/websocket/. This is so it can be optionally exposed to the webapp if you wish to use it as a provided dependency.