Fixes #5787 - Make ManagedSelector report better JMX data. #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SampleStatistics to record data and JMX methods to export it. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
reviewed
Jan 25, 2021
| @@ -144,6 +148,36 @@ protected void doStop() throws Exception | |||
| super.doStop(); | |||
| } | |||
|
|
|||
| @ManagedAttribute(value = "Total number of keys", readonly = true) | |||
| public int getTotalKeys() | |||
There was a problem hiding this comment.
Rename this getTotalSelectableKeys maybe?
| } | ||
|
|
||
| @ManagedOperation(value = "Resets the statistics", impact = "ACTION") | ||
| public void resetStats() |
There was a problem hiding this comment.
Are you really sure we want to expose this?
There was a problem hiding this comment.
I think it is good to have and easy to ignore if you don't want to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SampleStatistics to record data and JMX methods to export it.
Signed-off-by: Simone Bordet simone.bordet@gmail.com